Open
Conversation
f9ff770 to
9d50e73
Compare
cb82969 to
5df9e43
Compare
5df9e43 to
6f86b67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
PostgreSQL 18.3 was released February 26th, and I consider 18 to be stable now.
This will prompt users to migrate to 18.
PostgreSQL has changed where it expects data. The cleanest way I found to handle this is to set
PG_DATAmanuallyand mount the volume outside of
/var/lib/postgresql, to avoid issues that arise from conflicts between old and new.Old: Mount to
/var/lib/postgresql/dataNew: Mount to
/var/lib/postgresql,datais a symlink, DB is in<MAJOR_VERSION>/dockerI set
PGDATA=/var/lib/postgres-dataand mount the volume to there. That allows existing users to work and have slashing protection, it allows new setups, and it allows migration.Also strengthened error handling.
Pucker factor is high: A fatal bug here gets people slashed.
This is the third migration since the code was introduced. First was 15->16, second 16->17, now 17->18.